]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
shellEntry: Remove close method
authorRui Matos <tiagomatos@gmail.com>
Mon, 8 Apr 2013 14:04:25 +0000 (16:04 +0200)
committerRui Matos <tiagomatos@gmail.com>
Mon, 8 Apr 2013 19:02:03 +0000 (21:02 +0200)
GrabHelper already takes care of putting the key focus back on the
widget that had it when the grab was established.

ShellEntry's close() has recently become harmful since it's now called
from the menu's destroy() method and that is called in the entry's
destroy handler which means that this._entry might no longer be valid
at close() time.

https://bugzilla.gnome.org/show_bug.cgi?id=697560

js/ui/shellEntry.js

index 2256af07000518ced6c5e2f0822e45f36e4d71e9..e9a94a6923fdb40b56d83fbc20ddc09ee69205e9 100644 (file)
@@ -82,11 +82,6 @@ const EntryMenu = new Lang.Class({
             this.actor.grab_key_focus();
     },
 
-    close: function(animate) {
-        this._entry.grab_key_focus();
-        this.parent(animate);
-    },
-
     _updateCopyItem: function() {
         let selection = this._entry.clutter_text.get_selection();
         this._copyItem.setSensitive(!this._entry.clutter_text.password_char &&